refactor: load presets from core runtime.yaml (eliminate drift)#127
Merged
Conversation
- Remove hardcoded Presets map from dockerfile.go (was drifting from core/presets/*/runtime.yaml — caused pi to install wrong packages) - Add preset.go with LoadPresets() that reads runtime.yaml files from the fetched core directory at generate time - Thread presets through Generator → RenderDockerfile - Add SetPresets() for tests that don't have a core directory - Add retry with backoff (3 attempts, 2s/4s delay) for core download to handle transient GitHub 504s in CI Preset updates now take effect immediately on next generate without any CLI code changes — true data-driven presets.
donbader
force-pushed
the
refactor/dynamic-presets
branch
from
012814f to
d95f252
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The hardcoded
Presetsmap indockerfile.goduplicatedcore/presets/*/runtime.yamland drifted. This caused pi to install@anthropic-ai/claude-codeinstead of the correct packages. Every preset update required a CLI code change — violating the "plugins are pure data" principle.Changes
Dynamic presets (main fix)
preset.gowithLoadPresets(coreDir)— readsruntime.yamlfiles from fetched corePresetsmap entirelyRenderDockerfileaccepts presets as parameter instead of referencing global stateSetPresets()for tests without a core directoryDownload retry (bonus)
download()infetcher.goretries up to 3 times with backoff on 5xx errorsResult
Preset updates now take effect on next
generatewithout any CLI release. True data-driven presets.