fix: align tarball naming and remove dead internal/release#139
Merged
Conversation
- core-release.yml: asset name now matches shim's download URL
(agent-sandbox-core-v{ver}-{os}-{arch}.tar.gz)
- Remove internal/release/ — shim handles all downloading now
When an old agent-sandbox Go binary is found on PATH, the install script now overwrites it with the shim directly. No manual PATH changes needed — 'agent-sandbox upgrade' just works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two spec compliance gaps found during post-implementation audit:
Tarball filename mismatch — the shim expects
agent-sandbox-core-v{ver}-{os}-{arch}.tar.gzbut the release workflow was producingcore-{ver}-{os}-{arch}.tar.gz. Aligned the workflow to match the shim.Dead code removal —
internal/release/(fetcher + tests) is no longer used by anything. The shim handles all downloading. Removed.Changes
.github/workflows/core-release.yml— fix asset name templateinternal/release/— deleted (408 lines of dead code)