feat: add OTEL_LOG_TOOL_DETAILS and sync hook with production - #13
Merged
Conversation
- Add OTEL_LOG_TOOL_DETAILS=1 to all settings examples for skill name attribution on telemetry events - Sync langfuse_hook.py with production: sys.path fix to prevent local directories shadowing the SDK import, and permission governance tracking that creates Permission Events spans with flag summaries Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
doneyli
added a commit
that referenced
this pull request
Jul 15, 2026
Turns were previously emitted as one trace each, linked only by
session_id. Now every turn attaches to a deterministic trace id seeded
from the session id (create_trace_id + trace_context on the turn span),
so all turns of a session land in a single trace:
Trace (session)
Turn N (span)
Claude Response (generation)
Tool: X (span)
Permission Events (span, when flagged)
Preserves the sys.path import guard and Permission Events tracking from
PR #13. Also adds conservative secret redaction (sanitize_text /
sanitize_value, toggle with CC_LANGFUSE_REDACT=false) and log rotation.
Verified end-to-end against a local v3 instance: 3 turns -> 1 trace,
7 nested observations, injected secret not present in trace payload.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OTEL_LOG_TOOL_DETAILS=1to all 3 settings examples — enablesskill_nameand tool parameter details on telemetry events, needed for skill invocation trackinglangfuse_hook.pywith production: sys.path fix (prevents locallangfuse/dirs from shadowing the SDK) and permission governance tracking (Permission Eventsspans with flag summaries)Context
Investigation of skill invocation tracking in Langfuse revealed that without
OTEL_LOG_TOOL_DETAILS=1, skill names aren't attached to telemetry events. The hook also had production-only improvements not reflected in the template.Skill cross-turn linkage (zero-duration spans, no parent link between trigger and execution traces) is tracked as future work — it's an upstream Claude Code limitation (anthropics/claude-code#35319).
Fixes #12
Test plan
skill_nameappears in Langfuse tracespermission-events.jsonlhas entrieslangfuse/folder🤖 Generated with Claude Code