CI update#8
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| env: | ||
| QT_API: ${{ matrix.qt-binding }} | ||
| run: | | ||
| if ( "$RUNNER_OS" == "Linux" ); then | ||
| xvfb-run -a uv run --no-sync pytest | ||
| else | ||
| uv run --no-sync pytest | ||
| fi | ||
| uv run --no-sync pytest |
There was a problem hiding this comment.
Keep Linux pytest under a virtual display
Linux matrix jobs now invoke uv run --no-sync pytest directly without the previous xvfb-run wrapper. The test suite spins up Qt widgets via pytest-qt (e.g., qtbot.addWidget in tests/test_color_range_widget.py), and GitHub’s ubuntu-latest runners are headless with no DISPLAY, so Qt will abort with “Could not connect to display” and all Linux jobs will fail. Reintroduce xvfb-run (or set QT_QPA_PLATFORM=offscreen) when runner.os == 'Linux' to preserve the virtual display used before.
Useful? React with 👍 / 👎.
No description provided.