Fix: ValueError when x_dtype != y_dtype with numpy 2.x#36
Open
yousuke08 wants to merge 1 commit into
Open
Conversation
- Fix numpy 2.x compatibility issue in parse() method - Changed time data extraction from per-element assignment to buffer concatenation - Fixes 'ValueError: setting an array element with a sequence' - Tested with Python 3.14, numpy 2.4.2
|
Thx for that fix @yousuke08, works for me with Python 3.13.13 and numpy 2.4.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When parsing LTspice RAW files where
x_dtype(time data type) differs fromy_dtype(variable data type), the library raises a ValueError: ValueError: setting an array element with a sequence.TypeError: only 0-dimensional arrays can be converted to Python scalars
Root Cause
In
parse()method, whenx_dtype != y_dtype, the code tries to assign an array (returned bynp.frombuffer()) to a scalar position (self.x_raw[i]):Solution
Changed the approach to concatenate byte buffers first, then convert to array in one operation:
Testing
Environment