fix: ensure parser uses fresh response object for each ping to preven…#49
Merged
dopecodez merged 4 commits intodopecodez:masterfrom Oct 24, 2025
Merged
Conversation
…t shared state issues
Contributor
Author
Owner
|
Hey @Sahilhawal , thanks for the MR 🏅 Can we write a test case for the same? The fix makes sense from my side but we should make a few tests. |
Contributor
Author
|
Hey @dopecodez , |
Contributor
Author
|
Btw, this code fix is causing the parser test case to fail, as it was previously passing due to the same bug. Now that the bug is fixed, the test is failing as expected. |
Contributor
Author
|
@dopecodez I have updated the test cases as well, could you please take a look? |
dopecodez
approved these changes
Oct 24, 2025
Owner
|
Thanks @Sahilhawal for the MR. We will put out a new version of the package with this fix the coming weekend. Closes #46 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: ensure parser uses fresh response object for each ping to prevent shared state issues