Skip to content

Fix Release sample and ABI validation CI #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richiemsft merged 3 commits into from
Sep 17, 2026
Merged

Fix Release sample and ABI validation CI #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
875c8d6
Disable ReadyToRun in sample CI
richiemsft Sep 17, 2026
1ae1f67
Restore sample Release assets in CI
richiemsft Sep 17, 2026
ec48b50
Fix ABI workflow invocation
richiemsft Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,15 @@ jobs:
shell: pwsh
run: |
dotnet restore .\samples\ControllerApp\MatterControllerApp.csproj `
-p:Platform=x64 --configfile .\NuGet.config --force --no-cache
-p:Platform=x64 -p:Configuration=Release `
--configfile .\NuGet.config --force --no-cache
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
dotnet build .\samples\ControllerApp\MatterControllerApp.csproj `
-c Release -p:Platform=x64 --no-restore --nologo
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
dotnet restore .\samples\ControllerApp\MatterControllerApp.csproj `
-p:Platform=ARM64 --configfile .\NuGet.config --force --no-cache
-p:Platform=ARM64 -p:Configuration=Release `
--configfile .\NuGet.config --force --no-cache
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
dotnet build .\samples\ControllerApp\MatterControllerApp.csproj `
-c Release -p:Platform=ARM64 --no-restore --nologo
Expand Down Expand Up @@ -72,14 +74,15 @@ jobs:
shell: pwsh
run: |
. .\matterforwindows\scripts\setup\windows.ps1 -Architecture x64
$nativeDlls = @(
'.\out\win-winrt-x64\Matter.Windows.Controller.dll'
'.\out\win-winrt-arm64\Matter.Windows.Controller.dll'
)
.\tools\verify-abi.ps1 `
-BaselineWinmd $env:BASELINE_WINMD `
-CurrentWinmd .\out\win-winrt-x64\Matter.Windows.Controller.winmd `
-EquivalentWinmd .\out\win-winrt-arm64\Matter.Windows.Controller.winmd `
-NativeDll @( `
.\out\win-winrt-x64\Matter.Windows.Controller.dll, `
.\out\win-winrt-arm64\Matter.Windows.Controller.dll `
)
-NativeDll $nativeDlls

- name: Upload package
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.0
Expand Down
3 changes: 1 addition & 2 deletions samples/ControllerApp/MatterControllerApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@
<PropertyGroup>
<PublishReadyToRun Condition="'$(Configuration)' == 'Debug'">False</PublishReadyToRun>
<PublishReadyToRun Condition="'$(Configuration)' != 'Debug'">True</PublishReadyToRun>
<PublishTrimmed Condition="'$(Configuration)' == 'Debug'">False</PublishTrimmed>
<PublishTrimmed Condition="'$(Configuration)' != 'Debug'">True</PublishTrimmed>
<PublishTrimmed>False</PublishTrimmed>
</PropertyGroup>
</Project>