chore(core): sync Core → v3.0.0#28
Merged
Merged
Conversation
2f645e3 Merge pull request #130 from dotgibson/claude/nvchad-cheatsheet-expansion-fioord 7c388ee fix(nvim): list <leader>wk in cheatsheet + clamp float for the border 083b2e9 release v3.0.0 3b5f1c7 feat(nvim): add a full-screen keybinding cheatsheet git-subtree-dir: core git-subtree-split: 2f645e349cd43fbb3589b5674864e7a93f193909
There was a problem hiding this comment.
Pull request overview
Syncs the vendored core/ subtree to Core v3.0.0 and updates Neovim keybinding UX by introducing a full-screen cheatsheet and adjusting which-key access accordingly.
Changes:
- Add a new pure-Neovim
gerrrt.cheatsheetfloating-panel cheatsheet and bind it to<leader>?plus:Cheatsheet/:Cheat. - Move which-key’s buffer-local keymap popup from
<leader>?to<leader>wkand register a new<leader>wwhich-key group. - Bump Core provenance/version metadata (
core.version,core.lock,CHANGELOG.md) to v3.0.0.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| core/nvim/lua/gerrrt/plugins/which-key.lua | Adds <leader>w group and remaps which-key buffer-local popup to <leader>wk. |
| core/nvim/lua/gerrrt/config/keymaps.lua | Adds <leader>? cheatsheet mapping and :Cheatsheet/:Cheat user commands. |
| core/nvim/lua/gerrrt/cheatsheet.lua | Introduces the new full-screen keybinding cheatsheet renderer and floating window implementation. |
| core/core.version | Bumps vendored Core version to 3.0.0. |
| core/CHANGELOG.md | Documents the v3.0.0 release changes (cheatsheet + keybinding change). |
| core.lock | Updates pinned Core SHA/version metadata and records the tag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+23
to
+25
| vim.api.nvim_create_user_command("Cheatsheet", function() | ||
| require("gerrrt.cheatsheet").open() | ||
| end, { desc = "Open the keybinding cheatsheet" }) |
Comment on lines
+26
to
+28
| vim.api.nvim_create_user_command("Cheat", function() | ||
| require("gerrrt.cheatsheet").open() | ||
| end, { desc = "Open the keybinding cheatsheet" }) |
Comment on lines
+378
to
+389
| -- The rounded border adds a cell on every side, so the *outer* window is width+2 × height+2. | ||
| -- Clamp the inner size to columns-4 / lines-4 (border + a 1-cell margin) so nvim_open_win can | ||
| -- never be asked for a float larger than the grid — which would error on a very small terminal. | ||
| local width = math.max(1, math.min(content_w, vim.o.columns - 4)) | ||
| local height = math.max(1, math.min(#lines, math.floor(vim.o.lines * 0.9), vim.o.lines - 4)) | ||
| local win = vim.api.nvim_open_win(buf, true, { | ||
| relative = "editor", | ||
| width = width, | ||
| height = height, | ||
| row = math.floor((vim.o.lines - height) / 2), | ||
| col = math.floor((vim.o.columns - width) / 2), | ||
| style = "minimal", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Core fan-out from
dotfiles-corev3.0.0 (2f645e349cd4).Vendors the released Core into
core/viagit subtree pull --squashandbumps
core.lockto pin the exact released commit. Generated bydotfiles-core's
sync-fanoutworkflow.Merge per the staged rollout in
RELEASE-STRATEGY.md— canarydotfiles-MacBookfirst, bake, then the rest. Review the diff before merging.