fix(architecture): attribute up to the updater stage, not functions#80
Merged
Conversation
The load-order description listed `up` as a functions.zsh verb, but `up` is the updater defined in zsh/update.zsh (the separate maint/update stage). Swap it for `serve`, a real functions.zsh function, matching core.manifest's description of the functions stage. Fixes the one concrete drift found in the showcase-accuracy sweep (dotfiles-web#79). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PqpZTVtrhA18ZT7THnaUHu
There was a problem hiding this comment.
Pull request overview
This PR fixes a small documentation drift on the Architecture page by correcting the example verbs listed for the functions load-order stage so they reflect real functions.zsh entries (and don’t misattribute up, which belongs to the updater stage).
Changes:
- Update the
functionsstage description to replaceupwithservein the load-order table.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The load-order table on the architecture page described
upas afunctionsstage verb:But
upis not a function inzsh/functions.zsh— it's the updater defined inzsh/update.zsh:283, which the same page already lists separately as themaint / updatestage ("the up updater nudge").core.manifestdescribesfunctions.zshas(mkcd, extract, serve, genpw, ...).This swaps
upforserve— a realfunctions.zshfunction — so the copy matches the manifest.Change
src/pages/architecture.astro—up→servein thefunctionsstage description.This is the single concrete drift found in the
showcase-accuracysweep (#79). The report's optional "wire the hard-typed 'Ten' togenerated.json" hardening is not included here — it's accurate today, so it's left for a separate decision.Closes #79
🤖 Generated with Claude Code
https://claude.ai/code/session_01PqpZTVtrhA18ZT7THnaUHu
Generated by Claude Code