fix(ci): use read-only permission mode for the report-first routines#40
Merged
Conversation
--permission-mode acceptEdits auto-approves the file-edit tool category, which overrides the --allowedTools allowlist — so the routines' "report-first, change nothing" guarantee rested on the prompt + model compliance, not a hard rule. Switch every routine job to --permission-mode default: an edit call is no longer pre-approved (denied non-interactively in headless -p), while the allowlisted read/research tools still run. Makes report-only a mechanical guarantee. Surfaced by Copilot review on dotfiles-Windows#92; swept fleet-wide for parity. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012CpbBxJLgsg3T3ropqYGJA
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens the claude-routines.yml GitHub Actions workflow so the “report-first” Claude routines cannot perform non-interactive file edits, making report-only behavior mechanically enforced rather than prompt-dependent.
Changes:
- Switched all three Claude routine invocations from
--permission-mode acceptEditsto--permission-mode default. - Keeps existing
--allowedToolsread-oriented allowlists intact for the routines.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fleet-wide hardening surfaced by a Copilot review on dotfiles-Windows#92.
claude-routines.yml's jobs ran with--permission-mode acceptEdits, which auto-approves the file-edit tool category and overrides the--allowedToolsallowlist — so "report-first, change nothing" rested on the prompt + model compliance, not a hard rule.Flipped all 3 jobs (corpus-review, release-readiness, release-notes) to
--permission-mode default: an edit call is denied non-interactively in headless-p, while the allowlisted read tools still run. Report-only is now mechanical.actionlintclean; no behavior change (the routines never edit).🤖 Generated with Claude Code
Generated by Claude Code