Conversation
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
There was a problem hiding this comment.
Extending on @arhimede's patterns, I tried to come up with a generic pattern that would fit all handlers.
See my suggestions in the below table:
| Module | Verb | Resource | Action | Extra | Handler | Handler directory/file name | Route path | Route name |
|---|---|---|---|---|---|---|---|---|
| Admin | Get | Admin | Create | Form | Handler | Admin/GetAdminCreateFormHandler |
/admin/create-admin |
admin::admin-create-form |
| Admin | Post | Admin | Create | Handler | Admin/PostAdminCreateHandler |
/admin/create-admin |
admin::admin-create |
|
| Admin | Get | Admin | Edit | Form | Handler | Admin/GetAdminEditFormHandler |
/admin/edit-admin/{uuid} |
admin::admin-edit-form |
| Admin | Post | Admin | Edit | Handler | Admin/PostAdminEditHandler |
/admin/edit-admin/{uuid} |
admin::admin-edit |
|
| Admin | Get | Admin | Delete | Form | Handler | Admin/GetAdminDeleteFormHandler |
/admin/delete-admin/{uuid} |
admin::admin-delete-form |
| Admin | Post | Admin | Delete | Handler | Admin/PostAdminDeleteHandler |
/admin/delete-admin/{uuid} |
admin::admin-delete |
|
| Admin | Get | Admin | List | Handler | Admin/GetAdminListHandler |
/admin/list-admin |
admin::admin-list |
|
| Admin | Get | AdminLogin | List | Handler | Admin/GetAdminLoginListHandler |
/admin/list-admin-login |
admin::admin-login-list |
|
| Admin | Get | AdminAccount | Edit | Form | Handler | Account/GetAccountEditFormHandler |
/admin/edit-account |
admin::account-edit-form |
| Admin | Post | AdminAccount | Edit | Handler | Account/PostAccountEditHandler |
/admin/edit-account |
admin::account-edit |
|
| Admin | Post | AdminAccount | ChangePassword | Handler | Account/PostAccountChangePasswordHandler |
/admin/edit-account |
admin::account-change-password |
|
| Admin | Get | AdminAccount | Login | Form | Handler | Account/GetAccountLoginFormHandler |
/admin/login |
admin::admin-login-form |
| Admin | Post | AdminAccount | Login | Handler | Account/PostAccountLoginHandler |
/admin/login |
admin::admin-login |
|
| Admin | Get | AdminAccount | Logout | Handler | Account/GetAccountLogoutHandler |
/admin/logout |
admin::admin-logout |
|
| App | Get | Index | Redirect | Handler | GetIndexRedirectHandler |
/ |
app::index-redirect |
|
| Dashboard | Get | Dashboard | View | Handler | GetDashboardViewHandler |
/dashboard |
dashboard::dashboard-view |
|
| Page | Get | Page | View | Handler | GetPageViewHandler |
/page/component |
page::components |
|
| Setting | Get | Setting | View | Handler | GetSettingViewHandler |
/setting/{identifier} |
setting::setting-view |
|
| Setting | Post | Setting | Store | Handler | PostSettingStoreHandler |
/setting/{identifier} |
setting::setting-store |
|
| User | Get | User | Create | Form | Handler | GetUserCreateFormHandler |
/user/create-user |
user::user-create-form |
| User | Post | User | Create | Handler | PostUserCreateHandler |
/user/create-user |
user::user-create |
|
| User | Get | User | Delete | Form | Handler | GetUserDeleteFormHandler |
/user/delete-user/{uuid} |
user::user-delete-form |
| User | Post | User | Delete | Handler | PostUserDeleteHandler |
/user/delete-user/{uuid} |
user::user-delete |
|
| User | Get | User | Edit | Form | Handler | GetUserEditFormHandler |
/user/edit-user/{uuid} |
user::user-edit-form |
| User | Post | User | Edit | Handler | PostUserEditHandler |
/user/edit-user/{uuid} |
user::user-edit |
|
| User | Get | User | List | Handler | GetUserListHandler |
/user/list-user |
user::user-list |
|
| User | Post | UserAvatar | Edit | Handler | PostUserAvatarEditHandler |
/user/edit-user-avatar/{uuid} |
user::user-avatar-edit |
I know that introducing a few days ago the terms Resource and Collection was my idea, and now I'm dropping them, but while making the above table, they did not seem to make sense anymore.
The action View might sound MVC-ish, so if needed, it might be replaced with something more suitable.
Note that the route names also follow the same pattern:
module::resource-action-{form}
|
Maybe a more readable form of the same table from my previous comment:
|
|
@MarioRadu Try replacing dotkernel/dot-rbac-guard with dotkernel/dot-rbac-route-guard and let me know if you encounter any issues with the new package. |
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
|
@alexmerlin please merge when you think in branch 6 |
alexmerlin
left a comment
alexmerlin
left a comment
There was a problem hiding this comment.
We should rename add-admin-modal-content.html.twig to create-admin-modal-content.html.twig, just to match the naming pattern from GetAdminCreateFormHandler. (create vs add)
Or, maybe create-admin-form.html.twig?
If so, the all three *-admin-modal-content.html.twig templates should be called *-admin-form.html.twig
Let's also replace all occurrences of DotKernel with Dotkernel
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
alexmerlin
left a comment
alexmerlin
left a comment
There was a problem hiding this comment.
Navigation does not reflect current page.
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
alexmerlin
left a comment
alexmerlin
left a comment
There was a problem hiding this comment.
Table contents are not displayed if an admin does not have column settings for a specific table.
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
|
thanks @MarioRadu |
github-project-automation
bot
moved this from In Progress
to Done
in Headless Platform Roadmap
3 participants
No description provided.