Fixes: #88 invalid Abstract handler construction declaration#89
Merged
alexmerlin merged 1 commit intodotkernel:mainfrom Mar 12, 2025
Merged
Fixes: #88 invalid Abstract handler construction declaration#89alexmerlin merged 1 commit intodotkernel:mainfrom
alexmerlin merged 1 commit intodotkernel:mainfrom
Conversation
alexmerlin
requested changes
Mar 11, 2025
alexmerlin
reviewed
Mar 12, 2025
Member
alexmerlin
left a comment
alexmerlin
left a comment
There was a problem hiding this comment.
The only issue now is that optional arguments should come after the required ones.
Contributor
Author
Done. |
Fixes: dotkernel#88, move optional parameters after required ones
alexmerlin
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.