Sync GitHub master#32
Open
pvpcookie wants to merge 14 commits into
Open
Conversation
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…t-1.2.6 Bump minimist from 1.2.5 to 1.2.6
## What's being changed We've updated our compatibility with newer versions of WordPress and WooCommerce. The `WC requires at least` and `WC tested up to` tags have been moved to the main plugin file, because Woo only respects these, and doesn't look in readme.txt. ## Why it's being changed We've tested the plugin against WordPress v6.0 and WooCommerce 6.5.1. ## How to review / test this change - Download a 3.3.x Woo from https://developer.woocommerce.com/releases/ - Install locally - On the plugins page, you shouldn't see any warnings by the invitation to upgrade WooCommerce (e.g. 'Dotdigital for WooCommerce has not been tested against the newer version of WooCommerce') Related work items: #175984
…items ## What's being changed Cart insight data. ## Why it's being changed Cart insight line items' `salePrice` property is supposed to be the price paid by the customer at checkout (i.e. it can reflect a discount). In Woo, if there is no discount or sale on an item, `$product->get_sale_price()` returns an empty string. This change uses the regular price for the sale price, in these cases. ## How to review / test this change - Add a full price item to the basket - Add a sale item to the basket - Check the cart insight posted has the expected values for `salePrice` for both line items Related work items: #177402
Release note and version updates. Related work items: #177651
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.