Extend MinimalPermissionsPlugin by introducing the schemeName property#1391
Conversation
|
Thanks! We'll review it asap |
|
We're going to do a release tomorrow. To avoid adding last minute changes, we'll wait with reviewing/merging until after the release, later this week, ok? |
no worries, whenever is fine. |
There was a problem hiding this comment.
Pull Request Overview
This PR extends the MinimalPermissionsPlugin by introducing a schemeName property that allows users to specify which security scheme definition to use when determining minimal permissions for API calls.
- Adds
schemeNameconfiguration property to target specific OAuth2 security schemes - Updates permission checking logic to filter by the specified scheme name
- Enhances reporting to include scheme name information when available
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| schemas/v1.2.0/minimalpermissionsplugin.schema.json | Adds schemeName property definition to the JSON schema |
| DevProxy.Plugins/Reporting/MinimalPermissionsPluginReport.cs | Updates report classes to include and display scheme name information |
| DevProxy.Plugins/Reporting/MinimalPermissionsPlugin.cs | Integrates schemeName configuration into the plugin logic and logging |
| DevProxy.Plugins/Extensions/OpenApiDocumentExtensions.cs | Modifies OAuth2 scheme filtering to support scheme name targeting |
waldekmastykarz
left a comment
There was a problem hiding this comment.
Very clean! Let's do a few small adjustments and get it out there. 👏
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Updated v1.3 schema instead of v1.2. |
#1023