Extend MinimalPermissionsGuidancePlugin to support delegated and application permissions#1423
Merged
waldekmastykarz merged 6 commits intoOct 17, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the MinimalPermissionsGuidancePlugin to support different security scheme types (delegated and application permissions) by adding a configurable schemeName parameter. This allows the plugin to distinguish between different permission types when analyzing API calls and reporting minimal permissions.
Key changes:
- Added
schemeNameconfiguration option to specify the security scheme for permission analysis - Updated reporting to include the scheme name in output headers and messages
- Modified permission checking logic to pass the scheme name through the analysis pipeline
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| schemas/v1.3.0/minimalpermissionsguidanceplugin.schema.json | Added schemeName property to plugin configuration schema |
| DevProxy.Plugins/Reporting/MinimalPermissionsGuidancePluginReport.cs | Updated report generation to conditionally include scheme name in headers |
| DevProxy.Plugins/Reporting/MinimalPermissionsGuidancePlugin.cs | Added scheme name configuration, updated permission checking calls, and enhanced logging with scheme-specific messages |
waldekmastykarz
approved these changes
Oct 17, 2025
waldekmastykarz
left a comment
Collaborator
There was a problem hiding this comment.
Perfect! Nothing to add.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1393