Skip to content

Fix token metric unit to use UCUM format {token} #7241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephentoub merged 1 commit into from
Jan 29, 2026
Merged

Fix token metric unit to use UCUM format {token} #7241

stephentoub merged 1 commit into from
Jan 29, 2026
+1 −1

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Jan 29, 2026 •
edited by dotnet-policy-service bot
Loading

Microsoft Reviewers: Open in CodeFlow

@stephentoub stephentoub requested a review from tarekgh January 29, 2026 23:02
@stephentoub stephentoub requested a review from a team as a code owner January 29, 2026 23:02
Copilot AI review requested due to automatic review settings January 29, 2026 23:03
Copilot AI reviewed Jan 29, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the OpenTelemetry metric unit for token counts to the UCUM-compliant format expected by GenAI semantic conventions.

Changes:

  • Change TokensUnit from "token" to "{token}" in OpenTelemetryConsts.

tarekgh
tarekgh approved these changes Jan 29, 2026
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the token unit format from https://opentelemetry.io/docs/specs/semconv/gen-ai/gen-ai-metrics/#metric-gen_aiclienttokenusage.

Thanks @stephentoub!

@stephentoub stephentoub enabled auto-merge (squash) January 29, 2026 23:37
@stephentoub stephentoub merged commit 140e405 into dotnet:main Jan 29, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@tarekgh tarekgh tarekgh approved these changes

Assignees

@stephentoub stephentoub

Labels

area-telemetry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stephentoub @tarekgh