Fix Pullup/Pulldown setting in LibgpiodV2#2476
Open
pgrawehr wants to merge 18 commits intodotnet:mainfrom
Open
Fix Pullup/Pulldown setting in LibgpiodV2#2476pgrawehr wants to merge 18 commits intodotnet:mainfrom
pgrawehr wants to merge 18 commits intodotnet:mainfrom
Conversation
Not sure how this ever worked - mocking Span<T> is not allowed
We would need to test both direction and bias, but that's not worth it, since SetPinMode is not expected to be time critical.
dotnet-policy-service
bot
added
the
area-System.Device.Gpio
Ellerbach
approved these changes
Feb 23, 2026
Member
Ellerbach
left a comment
Ellerbach
left a comment
There was a problem hiding this comment.
Looks good and I know you've been testing all this on real hardware.
Contributor
|
Let's talk about it, my Pi5 is complaining with libgpiod2 detection used in all the tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2475, #2461
The "bias" mode setting on the LibgpiodV2 driver wasn't working correctly. There where two main issues:
Microsoft Reviewers: Open in CodeFlow