This repository was archived by the owner on Nov 20, 2023. It is now read-only.
Conversation
Member
This will leave you with brittle service code. It encourages the wrong defaults. |
Author
|
referring issue #443 |
Author
Totally get that your services should be fault tolerant, but I think It would help support the way tye injects env variables. Do you have any suggestions :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to solve #1608 & #652
it introduces the dependsOn yaml that looks for services that match the name and ensure the startup order is honoured.
For Example:
Should await the Redis server to start before the vote service.
I will write more E2E tests to validate this and ensure that environment variables are added to services.