Updated SilkyRGB API - #4
Open
chrizzo-hb wants to merge 34 commits into
Open
Conversation
Extended SilkyRGB API
RG Vita Pro support
Allow to set HW MODES
Aggressive color setting
Improved RG Vita Pro support
Improved default colorways
Small optimizations for joystick mode. Biggest gain is when joysticks aren't being used, cpu usage is much lower.
fix initial led flash/blink before effect takes over
Add-ambient-fix-joystick
Update input_fade.py
Create trimui-brick-pro.json
Create trimui-brick-pro.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made some changes to the API, I hope you don't mind:
get-colorsrouteget-palettesroute to contain the color namespalette.invertwithcolor.primary/color.secondaryIn the ES menu, we now have 3 option lists:
led.color.primaryandled.color.secondaryshould be relevant now (it is still possible to also set a palette directly though, I did not change that, I only override it with primary/secondary color for now)This gives users more flexibility to create their own custom palette, yet they can still benefit from the awesome presets you created!!
However, since they can now manually switch primary and secondary color anyway, the invert option is obsolete so I removed it.
I believe this change will streamline the API and make it a bit less confusing, yet more flexible for users.
I hope you agree with this change?