Remove use of eval on supported platforms#33
Open
GabrielCastro wants to merge 1 commit into
Open
Conversation
4bdd29d to
f49d77d
Compare
f49d77d to
afa7eaa
Compare
Owner
|
Nice, I didn't realize you can set the length of a function now. Looks like it's support on all "modern" Node.js runtimes (4+). I feel it would be weird to have this different of a behavior between the runtimes, as it seems with the issues opened here that not using eval is desired in a general stance, and I don't disagree. I will queue up a 3.0 release that will use the function length setting (your PR) and just only support Node.js 4+ 👍 |
|
It would be super nice to release this. The current release generates an error with rollup: Thanks for this module ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #20
This drops the use of eval on versions of node that support setting function arity