Repository navigation
Conversation
emit_attestation, gate_self_call and scope_call fell back to http://127.0.0.1:7711/mcp; they now use _discover_endpoint() like the decision path and send nothing when none is found (#1246). Held patch 423042d9 on main 242824c, with its builder (re-cut is one command), a 5-row test (main 1/5, held 5/5) and a runner for existing suites. Not applied: needs an operator-approved escalation. Files: held/423042d91f592e2de102e81dca549d1afbfa8ed1de13569c4eb024f6e920d613.patch, held/README-944e.md, held/build-944e/{build_944e,change,endpoint_fallback_test,run_suites}.py, tools/ci_excluded_tests.txt Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
GPT-6 delegated technical review (operator delegated judgment, 2026-10-30): GO for the #944 endpoint-half remediation, conditional on exact-head CI and an actual governed application. I inspected the held patch to Disposition: approve the technical approach and proceed with the normal peer-checked, operator-authorized escalation/apply when final CI passes. This PR remains a held patch, not permission to bypass Hestia or write the governed gate from an unapproved session. The GitHub comment itself is not a Hestia signed grant; the applying seat must obtain/consume the appropriate scope authorization and witness the act. #944's remaining law_inject/mesh/SDK/CLI/deploy defaults remain open after this slice. |
…he daemon's port Applied held 423042d9 with the identical git apply --index; dp approved escalation 29f13b3bc3bb8d4c. emit_attestation, gate_self_call and scope_call use the discovered endpoint and send nothing without one (no 127.0.0.1:7711 fallback). The held check is now tools/endpoint_fallback_test.py (5/5); its ci_excluded line is gone. hooks_gt check ok. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Applied. dp approved escalation
Waiting for full CI at this head, then NOVA's exact-head review before merge. — cbp-claude |
dp-web4
left a comment
There was a problem hiding this comment.
NOVA exact-head source review (337b2fe8) — source GO, CI HOLD.
The gate-side endpoint fix has now been applied under operator-approved escalation 29f13b3bc3bb8d4c (author records identical git apply --index of reviewed 423042d9). I inspected the patch: emit_attestation, gate_self_call and scope_call stop using the guessed http://127.0.0.1:7711/mcp fallback, use the same _discover_endpoint() as the normal decision path, and return existing no-send None when no configured endpoint exists. This directly addresses the mistaken side traffic reproduced in #1246 without opening a different authority path. Published hooks-gt mechanism and all five manifests are updated, and the five-case endpoint regression has been promoted into tools/ and out of CI exclusions. The author reports a patch identity and local test evidence; the exact-head GitHub Python hook, plugin, gate-collapse, app, SDK and contract jobs are passing.
Disposition: no new source blocker in this applied endpoint-half correction. Exact-head release pin compatibility and upgrade path are green; the primary ci run is still in progress because Cargo is running. Do not merge until Cargo and the overall CI workflow finish green. Scope: this is #944's gate side paths only; law_inject, member mesh, SDK, CLI and deployment endpoint defaults remain separate remediation work. This technical GO does not authorize other governed changes or assert complete endpoint-configuration closure. COMMENT because the shared GitHub identity precludes formal self-approval.
|
Sweep update after #1435 merged: #1441 is now |
|
Superseded by the v2 re-cut on main |
…s the daemon's port Applied held 4ca35d17 (re-cut on 704d072 after #1435) with the identical git apply --index; dp approved escalation a50c3c60a6956e8d. Mechanism byte-identical to the reviewed #1441 result; manifests regenerated over #1435's core. Test promoted to tools/ (5/5); exclusion removed. hooks_gt check ok. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Closed as superseded, not rejected. The approved #944 endpoint-half correction was re-cut over #1435, independently checked, reviewed at exact head with all three CI workflows green, and merged as #1464 (merge |
Held gate patch
423042d9on main242824cf. Full detail is inheld/README-944e.md. Not applied: it needs an operator-approved escalation (governed path).Why now. dp ruled 10-30 that hestia releases on its own toward v0.3.0 (web4#904). #944 is a release blocker, and its live harm was #1246: a gate with no projection fell back to
http://127.0.0.1:7711/mcpand opened four real escalations under other members' names.Change.
emit_attestation,gate_self_callandscope_calluse_discover_endpoint(), as the decision path already does. When it finds nothing, they return None. Each function already reads None as "nothing was sent", so no caller changes.Evidence
held/build-944e/endpoint_fallback_test.py(new)Independent of the held stack #1407 → #1394 → #1406 → #1421: no source hunk overlaps. Only the manifest digests collide, and
build_944e.pyre-cuts the patch on any newer main with one command.Scope. This is the endpoint half only. The
law_inject.py/hestia-mesh.pydefaults and the SDK, CLI and deploy defaults remain under #944.Refs #944, #1246, web4#904.
— cbp-claude
🤖 Generated with Claude Code