Skip to content

Add notifications endpoint#112

Merged
dpguthrie merged 2 commits intodpguthrie:mainfrom
nchylak:feat/add-notifications-endpoint
May 6, 2025
Merged

Add notifications endpoint#112
dpguthrie merged 2 commits intodpguthrie:mainfrom
nchylak:feat/add-notifications-endpoint

Conversation

@nchylak
Copy link
Copy Markdown
Contributor

@nchylak nchylak commented Mar 27, 2025

Implements dbt Cloud's API notifications endpoint as discussed in issue #111

The changes were tested as detailed in the pytest files, using our company dbt Cloud's account and were successful on our side :)

Comment on lines +59 to +71
@pytest.mark.dependency(depends=["test_list_projects"])
def test_list_users():
_test_cloud_cli(
[
"users",
"list",
"--account-id",
ACCOUNT_ID,
],
"user_id",
)


Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We needed this additional test for using pytest.user_id in the notifications tests

@nchylak
Copy link
Copy Markdown
Contributor Author

nchylak commented Apr 7, 2025

Hey @dpguthrie, let me know if I can do anything here!

dbtc/_version.py Outdated
@@ -1 +1 @@
__version__ = "0.11.6"
__version__ = "0.12.0"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can prolly just be 0.11.7 as there are no breaking changes (unless I missed something). Other than that, looks good (and so sorry that it's taken so long for me to review).

@dpguthrie
Copy link
Copy Markdown
Owner

@nchylak apologize for being so late here - just had one comment. Should be good other than that.

@nchylak
Copy link
Copy Markdown
Contributor Author

nchylak commented May 5, 2025

apologize for being so late here - just had one comment. Should be good other than that.

No problem! The version is adjusted :)

@nchylak nchylak requested a review from dpguthrie May 5, 2025 09:52
@dpguthrie dpguthrie merged commit 6499ee4 into dpguthrie:main May 6, 2025
@nchylak nchylak deleted the feat/add-notifications-endpoint branch May 8, 2025 08:35
@nchylak
Copy link
Copy Markdown
Contributor Author

nchylak commented May 8, 2025

Thanks! Could you please also release this new version so that we can use it at my company 🙏 ?

@dpguthrie
Copy link
Copy Markdown
Owner

Thanks! Could you please also release this new version so that we can use it at my company 🙏 ?

0.11.7 should be installable via pypi now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants