Coderabbit test#14
Closed
dprital wants to merge 2 commits into
Closed
Conversation
…t#3988) Why I did it When running the test_fwutil_update_current test in https://github.com/sonic-net/sonic-mgmt/blob/master/tests/platform_tests/fwutil/test_fwutil.py we encounter the following issue when we run the command admin@sonic:$ sudo fwutil update chassis component ONIE fw -y Error: Failed to parse "platform_components.json": invalid platform schema: "module" key hasn't been found. Aborting... Aborted! This is because platform_components.json for smartswitch doesn't have module key in it and this should be ignored for smartswitch. What I did Avoid any modular chassis operations on smart-switch. How I did it Added a check to verify the device is not a smart switch before treating it as a modular chassis.
Owner
Author
|
bugbot run |
Owner
Author
|
/run bugbot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)