fix(dracut-install): resolve libraries even if not executable - #2195
Closed
bdrung wants to merge 1 commit into
Closed
fix(dracut-install): resolve libraries even if not executable#2195bdrung wants to merge 1 commit into
bdrung wants to merge 1 commit into
Conversation
Library files on Debian/Ubuntu are not marked as executable. This causes `dracut-install` to not resolve dependencies: ``` $ ls -l /usr/lib/x86_64-linux-gnu/libarchive.so.13.7.7 -rw-r--r-- 1 root root 874648 Jun 25 2025 /usr/lib/x86_64-linux-gnu/libarchive.so.13.7.7 $ rm -rf foo && mkdir foo $ ./dracut-install -D foo -l /usr/lib/x86_64-linux-gnu/libarchive.so.13 $ find foo foo foo/usr foo/usr/lib foo/usr/lib/x86_64-linux-gnu foo/usr/lib/x86_64-linux-gnu/libarchive.so.13.7.7 foo/usr/lib/x86_64-linux-gnu/libarchive.so.13 ``` There is no requirement for library files to be executable. So resolve dependencies for files that look like libraries (file name containing `.so`). Fixes: dracut-ng#2193
Collaborator
|
Shouldn't this also check if the file has an ELF binary file magic? |
Member
Author
|
We could instead just remove the executable condition (but then we would also resolve scripts that are not executable). |
Collaborator
|
@chewi - this issue might not impact you, but I am wondering if you could help us with ideas/review. Thanks ! |
Member
Author
Here is an alternative: #2196 |
Member
|
I'm a little surprised we're only noticing this now. This change is good though. The alternative is better. |
Member
Author
This has only be the case since the initial dracut-install commit 026b81e in 2012. 😆 |
Member
Author
|
#2196 got merged. So this approach is obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Library files on Debian/Ubuntu are not marked as executable. This causes
dracut-installto not resolve dependencies:There is no requirement for library files to be executable. So resolve dependencies for files that look like libraries (file name containing
.so).This is part one of two for fixing #2193.
Checklist