feat(resume): add device used for resume - #2232
Draft
pvalena wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
modules
Member
Author
|
Log with dracut test run with debug on -- diff from run on Fedora Rawhide 109, with the only change being this patch: https://gist.github.com/pvalena/56bad65a423d8daa4340698c4120de1a |
tbzatek
reviewed
Feb 18, 2026
regardless of whether it's mounted.
pvalena
force-pushed
the
fix-resume-drive
branch
from
April 10, 2026 19:01
9d63c6a to
5f6f81d
Compare
devkontrol
reviewed
Jun 15, 2026
| _dev=$(_get_resume_dev) | ||
| [[ $_dev ]] && push_user_devs "$_dev" | ||
|
|
||
| _dev=$(grep -oP "resume=\K([^ ]*)" /proc/cmdline) |
Collaborator
There was a problem hiding this comment.
Should this read e.g. /etc/cmdline.d/*.conf as well ?
Also I think /proc/cmdline should be only read if hostonly is set to yes.
devkontrol
added
needs discussion
devkontrol
marked this pull request as draft
August 10, 2026 11:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device used in
resume=might be on a different filesystem than root device, but it might not be mounted. Adding it explicitly regardless of whether it's mounted fixes the issue in which there might be missing drivers in initrd to actually check whether the system can be resumed.RFC: Please suggest if any refactoring or behaviour change would be benefitial in this this very rare scenario. This is just intended to increase resiliency.
Checklist