Log missing files from dracut-install and inst_simple - #2621
Merged
Conversation
3 tasks
devkontrol
approved these changes
Aug 19, 2026
airtower-luna
force-pushed
the
log-missing-files
branch
from
August 20, 2026 11:13
c3af1f2 to
73c65d0
Compare
devkontrol
previously approved these changes
Aug 20, 2026
Contributor
Author
|
Is it helpful if I rebase for any changes in |
Collaborator
if no conflict, not needed. Hopefully @bdrung will have. chance to review soon |
Files missing without any indication why causes trouble when debugging initramfs builds.
bdrung
reviewed
Aug 20, 2026
Files missing without any indication why causes trouble when debugging initramfs builds.
If hostonly mode is enabled, a possible -H option is shifted out before processing the numbered arguments. If -H was passed and hostonly mode disabled, inst_simple would treat "-H" as a non-existing file and return an error code, skipping the actual file. The previous commit added a warning about missing source files, leading to spurious warnings with -H. Instead, explicitly skip inst_simple calls with -H if hostonly mode is disabled, and log a debug level message.
airtower-luna
force-pushed
the
log-missing-files
branch
from
August 20, 2026 13:27
73c65d0 to
9b7eeae
Compare
devkontrol
approved these changes
Aug 20, 2026
bdrung
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files missing without any indication why causes trouble when debugging initramfs builds. I added these while working on #2588, @bdrung suggesting splitting the commits out so they can be merged already.
Checklist