Skip to content

Give redirects the correct path to the new URL - #1

Open
ryanweal wants to merge 1 commit into
drager:masterfrom
kafeiinteractif:master
Open

Give redirects the correct path to the new URL#1
ryanweal wants to merge 1 commit into
drager:masterfrom
kafeiinteractif:master

Conversation

@ryanweal

Copy link
Copy Markdown

Hello,

I found when I tried to use redirects with the following parameters:

.use(aliases({redirect:true}))

...it correctly adds the metatags but they are all set to "undefined".

This pull request puts the correct URL of the new post allowing the redirects to function as intended.

PS. I'm unsure why the last line of the file was flagged as changed by git. If you have any insight, I'm glad to hear it. Perhaps it is why it requests a newline at the end of the file.

Thanks for this plugin!

@ryanweal

Copy link
Copy Markdown
Author

I ended up going further down the rabbit hole and made a different version of the plugin that renders nginx config so the duplicate files are not necessary. You can see that here if interested: https://github.com/ryanweal/metalsmith-aliases-nginx

@drager

drager commented Apr 11, 2017

Copy link
Copy Markdown
Owner

Hi, thank you for the PR. I believe the problem occurred because you haven't installed the permalinks plugin which this package depends on.

Great with a different version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants