Skip to content

chore: enable rdb_sbf_chunked by default #7475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romange wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −5
Open

chore: enable rdb_sbf_chunked by default #7475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd10c32
chore: enable rdb_sbf_chunked by default
romange Jun 1, 2026
3dab45f
chore: add "never push to main" rule to CLAUDE.md
romange Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
`ninja <unit_test> && ./unit_test`
4. ✅ **Format Code** - `pre-commit run --files <files>`
5. ✅ **Follow Architecture** - See [Architecture Patterns](#architecture-patterns) below
6. ✅ **Never Push to Main** - Always create a feature branch and open a PR. Never run `git push origin main`.

### Pull Request Guidelines

Expand Down
3 changes: 1 addition & 2 deletions src/server/rdb_save.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ ABSL_FLAG(dfly::CompressionMode, compression_mode, dfly::CompressionMode::MULTI_
"set 2 for multi entry zstd compression on df snapshot and single entry on rdb snapshot,"
"set 3 for multi entry lz4 compression on df snapshot and single entry on rdb snapshot");

// Flip this value to 'true' in March 2026.
ABSL_FLAG(bool, rdb_sbf_chunked, false, "Enable new save format for saving SBFs in chunks.");
ABSL_FLAG(bool, rdb_sbf_chunked, true, "Enable new save format for saving SBFs in chunks.");
Copy link
Copy Markdown

@augmentcode augmentcode Bot Jun 1, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/server/rdb_save.cc:56: The flag help text still says "new save format" even though it’s now the default; this could become misleading for users trying to understand current behavior.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.


namespace dfly {

Expand Down
1 change: 0 additions & 1 deletion src/server/rdb_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,6 @@ TEST_F(RdbTest, SBF) {
}

TEST_F(RdbTest, SBFLargeFilterChunking) {
absl::SetFlag(&FLAGS_rdb_sbf_chunked, true);
max_memory_limit = 200000000;

// Using this set of parameters for the BF.RESERVE command resulted in a
Expand Down
2 changes: 0 additions & 2 deletions tests/dragonfly/replication_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4239,7 +4239,6 @@ async def test_sbf_chunked_replication(df_factory: DflyInstanceFactory):
master = df_factory.create(
Comment thread
romange marked this conversation as resolved.
proactor_threads=1,
maxmemory="6G",
rdb_sbf_chunked="true",
)
replica = df_factory.create(
proactor_threads=1,
Expand Down Expand Up @@ -4270,7 +4269,6 @@ async def test_sbf_chunked_replication_chunk_size(df_factory: DflyInstanceFactor
master = df_factory.create(
proactor_threads=1,
maxmemory="4G",
rdb_sbf_chunked="true",
)
replica = df_factory.create(
proactor_threads=1,
Expand Down
Loading