service: reduce fscache blob init lock scope - #1992
Open
Park-Jiyeonn wants to merge 1 commit into
Open
Conversation
Move blob initialization and prefetch work out of the fscache blob lock. Wait for initialization only when read or close needs the blob, so concurrent requests do not block on long I/O. Signed-off-by: Park.Jiyeon <jiyeonnn2@icloud.com>
There was a problem hiding this comment.
Pull request overview
This PR refactors FsCacheHandler’s fscache data-blob initialization flow to reduce the time spent holding the per-blob lock, aiming to improve concurrency by letting other requests proceed while blob creation/prefetch setup occurs in the background.
Changes:
- Introduced an init synchronization state (
FsCacheBlobInitState+ guard) to coordinate when blob initialization is considered complete. - Moved blob creation and prefetch planning out of the
RwLockwrite-lock critical section; only the cache assignment takes the write lock. - Updated read/close paths to wait for initialization completion only when the blob is actually needed.
Comment on lines
+250
to
+255
| fn wait(&self) { | ||
| let mut done = self.done.lock().unwrap(); | ||
| while !*done { | ||
| done = self.condvar.wait(done).unwrap(); | ||
| } | ||
| } |
Comment on lines
+223
to
+227
| #[derive(Default)] | ||
| struct FsCacheBlobInitState { | ||
| done: Mutex<bool>, | ||
| condvar: Condvar, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Move blob initialization and prefetch work out of the fscache blob lock. Wait for initialization only when read or close needs the blob, so concurrent requests do not block on long I/O.
Change Type
Please select the type of change your pull request relates to: