Skip to content

Fix deprecations for PHP 8.4 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dragosprotung merged 1 commit into from
Jun 15, 2026
Merged

Fix deprecations for PHP 8.4 #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/PHPClass2WSDL.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ protected function addMethodToWsdl(ReflectionMethod $method, DOMElement $port, D

// Add any documentation for the operation.
$description = $method->getReflectionDocComment()->getFullDescription();
if (isset($description) && (strlen($description) > 0)) {
if (strlen($description) > 0) {
$this->wsdl->addDocumentation($portOperation, $description);
}

Expand Down
7 changes: 3 additions & 4 deletions src/WSDL.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ public function __construct($name, $uri, $xslUri = null)
* Set the stylesheet for the WSDL.
*
* @param string $xslUri The URI to the stylesheet.
* @return WSDL
*/
private function setStylesheet($xslUri)
{
Expand Down Expand Up @@ -211,12 +210,12 @@ public function addSoapBinding(
*
* @param DOMElement $binding The binding element (from addBinding() method).
* @param string $name The name of the operation.
* @param array $input Attributes for the input element (use, namespace, encodingStyle).
* @param array $output Attributes for the output element (use, namespace, encodingStyle).
* @param array|null $input Attributes for the input element (use, namespace, encodingStyle).
* @param array|null $output Attributes for the output element (use, namespace, encodingStyle).
* @return DOMElement
* @link http://www.w3.org/TR/wsdl#_soap:body
*/
public function addBindingOperation(DOMElement $binding, $name, array $input = null, array $output = null)
public function addBindingOperation(DOMElement $binding, $name, ?array $input = null, ?array $output = null)
{
$operation = $this->dom->createElement('operation');
$operation->setAttribute('name', $name);
Expand Down
Loading