fix: ProseReadView hyperlink attribute styling and CLI doctor engine check - #212
Merged
Merged
Conversation
|
SummaryCoverage spans engine health and discovery behavior across configured, missing, non-executable, and unavailable executables, including success, warning, failure, fallback, and exit-status handling. It also checks read-mode rendering for links, normal surrounding text styling, and malformed imported content, including an adversarial review of the intended fallback behavior. Safe to merge — the run found no regressions, new failures, or previously flagged failures attributable to this PR, and all exercised behaviors were accepted. Any environment limitations or unrelated observations are not merge blockers. Tests run by Ito
Tip Reply with @itoqa to send us feedback on this test run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary of Changes
ProseReadView Hyperlink Styling ():
guard value != nil else { return }inpage.enumerateAttribute(.link, in: full).BanalCLI Doctor Check Engine Fallback ():
binaryCheckto explicitly test whether a configured path exists and is executable before falling back to automatic locator resolution.banal doctorcorrectly reports statusfailwhen an explicitly configured binary is missing, keepingBANALCLITestsgreen.