feat(editor): allowlist graph export and proof verify, and keep conflict compare at the top - #987
Merged
Merged
Conversation
…ict compare at the top Authors can take a compiler-owned Mermaid/DOT artifact and verify a Proof Pack without leaving the editor, and both compare panes start at the top so a long dirty buffer is not mistaken for a large structural diff. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
SummaryCoverage spans core editor workflows, including diagnostics and graph export, proof verification, navigation, unsaved-change safeguards, and external file conflict resolution. It also exercises edge cases where disk content changes during conflict handling or commands are attempted with dirty files, with the observed product behavior healthy across these areas. Safe to merge — no regressions, new failures, or previously flagged failures attributable to this PR were identified. A few environment-dependent checks could not exercise the editor, but they are unrelated observations rather than merge blockers. Tests run by Ito
Tip Reply with @itoqa to send us feedback on this test run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
boris graph(Mermaid by default, Graphviz DOT as the second option) andboris proof verify --html-dir distas read-only host modes; the UI copies or downloads compiler stdout and surfaces the contracted stderr verdict.Closes #983
Closes #984
Closes #985
Closes #986
Test plan
zig build testzig build --build-file editor/build.zig testcd editor/ui && npm run checkcd editor/ui && npx playwright test(191 passed)./editor/scripts/test-diagnostics.sh ./zig-out/bin/boris ./editor/zig-out/bin/boris-editor editor/ui/dist./editor/scripts/test-host-contract.sh ./zig-out/bin/boris ./editor/zig-out/bin/boris-editor editor/ui/distAgent Completion Report
t3code/editor-four-issue-fixest3code/editor-four-issue-fixes7bc209becc3dcb45774b046a767b80cb1d9d4c63maincontent/guides/editor.mddocs/contracts/editor-host.mddocs/changelog.d/983-986-editor-cli-surface.mdeditor/README.mdeditor/scripts/test-diagnostics.sheditor/src/runner.zigeditor/src/server.zigeditor/ui/src/App.svelteeditor/ui/src/components/GraphPane.svelteeditor/ui/src/components/ProblemsPane.svelteeditor/ui/src/components/PublicationPane.svelteeditor/ui/src/components/SourcePane.svelteeditor/ui/src/dialogs/ConflictDialog.svelteeditor/ui/src/lib/state/graph.svelte.tseditor/ui/src/lib/state/palette.svelte.tseditor/ui/src/lib/state/publication.svelte.tseditor/ui/src/lib/types.tseditor/ui/src/lib/utils.tseditor/ui/src/styles.csseditor/ui/tests/safe-editing.spec.tseditor/ui/tests/section-nav.spec.tst3code/microcopy-and-editor-polish-pass,t3code/fix-graph-fit-undo-preview,t3code/editor-graph-map-zoom) left intact.CommandModenow includesgraph_exportandproof_verifywith fixed argv, optionalgraph_format(mermaid/dot), and result fieldsgraph_document/proof_report.scrollTopand caret aftershowModaland focuses the primary button so the unsaved pane no longer opens at the end.zig build testzig build --build-file editor/build.zig testzig build && zig build --build-file editor/build.zigcd editor/ui && npm run checkcd editor/ui && npm run buildcd editor/ui && npx playwright test./editor/scripts/test-diagnostics.sh ./zig-out/bin/boris ./editor/zig-out/bin/boris-editor editor/ui/dist./editor/scripts/test-host-contract.sh ./zig-out/bin/boris ./editor/zig-out/bin/boris-editor editor/ui/distzig build test: passzig build --build-file editor/build.zig test: passnpm run check(editor/ui): 0 errors / 0 warnings; key-hints conformance OKnpx playwright test(editor/ui): 191 passed./editor/scripts/test-diagnostics.sh:editor Boris diagnostics integration: ok./editor/scripts/test-host-contract.sh:editor host contract conformance: okgraph --input content --format mermaid|dot,proof verify --html-dir dist);--cooklangis appended to graph export on cooklang trees and omitted for proof verify.editor/ui/distfromnpm run build(not committed). Zig caches not committed.Made with Cursor