chore: verify fix for #120 — quoted scalars with ": " (no code change) - #124
Closed
drawmeanelephant wants to merge 1 commit into
Closed
drawmeanelephant wants to merge 1 commit into
drawmeanelephant wants to merge 1 commit into
Conversation
Fix already shipped in #121 (b830475) and is on main (f1fbb1c). Verified on oliver 1.0.0 at f1fbb1c: - zig build test --summary all: 455/455 passed - oliver meta --from markdown --format json: all 6 rows of the characterization table pass (quoted double/single, trailing, no-space, bare stays empty). See src/meta.zig:495 and src/frontmatter.zig:757 regression tests. Closes #120
Owner
Author
|
SummaryCoverage focuses on the metadata command’s normal extraction behavior and edge cases around quoted values, colons, comments, unsupported bare values, tagged values, required fields, and excluding document body content. Overall, the exercised behavior appears healthy across both standard and boundary-input scenarios. Safe to merge — the run found no failures attributable to this PR, including no regressions, new failures, or previously reported failures that remain unresolved. The covered metadata behavior presents no merge-blocking risk. Tests run by Ito
Tip Reply with @itoqa to send us feedback on this test run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix already shipped in #121 (
b830475→c91db48) and is onmain(f1fbb1c). This PR only verifies and closes #120 which remained open (noFixes #120magic in #121).Verification on
main(f1fbb1c,oliver 1.0.0)E2E CLI checks (all pass):
title: "Has: Colon"→Has: Colondescription: "Desc: here"+author: "A: B"→ all three kepttitle: 'Single: Colon'→ kepttitle: "NoSpace:Colon"→ kepttitle: "Trailing: "→Trailing:verbatimtitle: Unquoted: Colon Value→""(bare out-of-subset, expected)Unit tests pinning the fix:
src/meta.zig:495meta: quoted scalars may contain \": \"src/frontmatter.zig:757frontmatter yaml: quoted scalars may contain \": \"No code change — empty commit for closure.
Closes #120