Skip to content

chore: verify fix for #120 — quoted scalars with ": " (no code change) - #124

Closed
drawmeanelephant wants to merge 1 commit into
mainfrom
t3code/verify-120-e2e
Closed

drawmeanelephant wants to merge 1 commit into
mainfrom
t3code/verify-120-e2e

Conversation

@drawmeanelephant

Copy link
Copy Markdown
Owner

Fix already shipped in #121 (b830475c91db48) and is on main (f1fbb1c). This PR only verifies and closes #120 which remained open (no Fixes #120 magic in #121).

Verification on main (f1fbb1c, oliver 1.0.0)

git pull --ff-only  # main now at f1fbb1c (includes #121 + #123)
zig build test --summary all  # 455/455 passed
# reproduction from #120 — all rows of the characterization table:
printf '---\ntitle: "Has: Colon"\n---\nx\n' | oliver meta --from markdown --format json
# → {"title":"Has: Colon",…}  (was "" before #121)

E2E CLI checks (all pass):

  • title: "Has: Colon"Has: Colon
  • description: "Desc: here" + author: "A: B" → all three kept
  • title: 'Single: Colon' → kept
  • title: "NoSpace:Colon" → kept
  • title: "Trailing: "Trailing: verbatim
  • title: Unquoted: Colon Value"" (bare out-of-subset, expected)

Unit tests pinning the fix:

  • src/meta.zig:495 meta: quoted scalars may contain \": \"
  • src/frontmatter.zig:757 frontmatter yaml: quoted scalars may contain \": \"

No code change — empty commit for closure.

Closes #120

Fix already shipped in #121 (b830475) and is on main (f1fbb1c).
Verified on oliver 1.0.0 at f1fbb1c:

- zig build test --summary all: 455/455 passed
- oliver meta --from markdown --format json: all 6 rows of the
  characterization table pass (quoted double/single, trailing,
  no-space, bare stays empty). See src/meta.zig:495 and
  src/frontmatter.zig:757 regression tests.

Closes #120
@drawmeanelephant

Copy link
Copy Markdown
Owner Author

Issue #120 was closed directly via gh issue close after verification that the fix is already on main (f1fbb1c, #121). No code change needed — closing this verification PR as completed/no-op. See close comment on #120 for evidence (455/455 tests, CLI reproduction).

@drawmeanelephant
drawmeanelephant deleted the t3code/verify-120-e2e branch August 26, 2026 13:57
@itoqa

itoqa Bot commented Aug 26, 2026

Copy link
Copy Markdown

Ito QA test results
Commit: 610b3f0: 2 test cases ran, 2 passed ✅.

Summary

Coverage focuses on the metadata command’s normal extraction behavior and edge cases around quoted values, colons, comments, unsupported bare values, tagged values, required fields, and excluding document body content. Overall, the exercised behavior appears healthy across both standard and boundary-input scenarios.

Safe to merge — the run found no failures attributable to this PR, including no regressions, new failures, or previously reported failures that remain unresolved. The covered metadata behavior presents no merge-blocking risk.

Tests run by Ito

View full run

Result Severity Type Description
Rev The metadata command kept the quoted title and returned empty strings for unsupported bare, comment, and tagged values. It also returned all seven expected fields.
Rev The metadata command preserved quoted title, description, and author values containing colons. It returned all seven expected fields and left the document body out of the JSON.

Tip

Reply with @itoqa to send us feedback on this test run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

meta: quoted frontmatter scalars containing ": " are silently dropped

1 participant