feat(wrap): extended template dialect — version, subtitle, tags, asset_meta tokens - #126
Merged
Merged
Conversation
…t_meta tokens Extends the 7-token wrap dialect with the v2 shared template contract tokens (rotkeeper #244): $version$, $subtitle$, $tags$, $asset_meta$, $navigation$, $warnings$. MetaJson carries the new optional scalar fields, fieldVal/isKnownField cover them (html-escaped substitution, $if$ gating, absent-known → empty, unknown → verbatim), and the unit suite covers substitution, escaping, gating, and absence semantics. Generated with Codebuff 🤖 Co-Authored-By: Codebuff <noreply@codebuff.com>
5 tasks
|
SummaryCoverage spans normal template rendering and business rules for conditional sections, metadata substitution, escaping, token ordering, and literal content insertion. It also exercises edge and adversarial inputs, including missing or empty values, unknown and malformed conditional syntax, and invalid metadata, with no application behavior problems found. Safe to merge — the exercised rendering and input-handling behavior is healthy, with no regressions, new failures, or previously flagged failures attributable to this PR. No merge-blocking risk is indicated. Tests run by Ito
Tip Reply with @itoqa to send us feedback on this test run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Extends the
oliver wrap7-token template dialect with the shared template contract v2 tokens (rotkeeper #244):$version$,$subtitle$,$tags$,$asset_meta$,$navigation$,$warnings$.MetaJsongains the six optional scalar fields;fieldVal/isKnownFieldcover them with the existing semantics — html-escaped substitution,$if$gating, absent-known → empty, unknown → verbatim.oliver meta(still the seven S1 fields); the rotkeeper adapter feeds the extended keys into--meta-json(version frombones/config/version, the rest from source frontmatter via yq).Rotkeeper will move
OLIVER_PINto this commit after merge so thebuildsrelease serves the v2 dialect.Validation
zig build test— full suite green (460 tests)wrapprobe:$version$/$subtitle$/$tags$/$asset_meta$substitute escaped,$if(version)$gates,$unknown$passes verbatimGenerated with Codebuff 🤖
Co-Authored-By: Codebuff noreply@codebuff.com