Feature/workspace setup 20251119 - #275
Open
drdave-flexnetos wants to merge 5 commits into
Open
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ate dependencies (#262) * Initial plan * Fix review comments: generalize workspace path and clean up duplicate dependencies Co-authored-by: FlexNetOS <211752339+FlexNetOS@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: FlexNetOS <211752339+FlexNetOS@users.noreply.github.com>
Resolved conflicts in: - Cargo.toml: kept thiserror 2.0 - notebooks/requirements.txt: merged with latest versions - ui/vibe-kanban/package.json: included ESLint dependencies
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the workspace setup and performs a major dependency upgrade for the vibe-kanban UI package. The changes include upgrading to Tailwind CSS v4, Vitest v4, Testing Library v16, and several other dependencies. The workspace setup documentation is also generalized to remove user-specific paths.
Key changes:
- Major version upgrades for Tailwind CSS (3.4.3 → 4.1.17), Vitest (1.5.0 → 4.0.10), and Testing Library React (14.2.1 → 16.3.0)
- Addition of new ESLint configuration packages
- Update of multiple other dependencies to newer versions
- Generalization of workspace path in documentation
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ui/vibe-kanban/package.json | Adds ESLint packages, reorganizes devDependencies, and upgrades multiple major versions including Tailwind CSS v4, Vitest v4, and Testing Library v16 |
| pnpm-lock.yaml | Updates lock file with new dependency resolution tree reflecting all package.json changes, including removal of Tailwind v3 dependencies and addition of v4 |
| WORKSPACE_SETUP.md | Generalizes workspace path from user-specific to placeholder for better documentation portability |
Comments suppressed due to low confidence (2)
ui/vibe-kanban/package.json:45
- Tailwind CSS v4 is a major rewrite with significant breaking changes from v3. Ensure that all Tailwind configuration files (tailwind.config.js/ts) and usage patterns have been updated to match v4's new architecture. V4 uses CSS-first configuration and has removed several v3 features. Verify that the build still works and all styles render correctly.
"tailwindcss": "4.1.17",
ui/vibe-kanban/package.json:47
- Vitest v4 includes breaking changes from v1, including changes to the configuration API and test environment setup. Ensure that vitest.config.ts has been updated to match v4's configuration schema and that all test files still run correctly with the new version.
"vitest": "4.0.10"
| "@eslint/eslintrc": "3.2.0", | ||
| "@eslint/js": "9.15.0", | ||
| "@testing-library/jest-dom": "6.9.1", | ||
| "@testing-library/react": "16.3.0", |
There was a problem hiding this comment.
Testing Library React v16 requires peer dependencies @testing-library/dom v10 and has stricter type requirements. The package now requires explicit @types/react and @types/react-dom peer dependencies (both present in this config). Verify that all existing tests pass with v16's stricter behavior and updated APIs.
Suggested change
| "@testing-library/react": "16.3.0", | |
| "@testing-library/react": "16.3.0", | |
| "@testing-library/dom": "10.0.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.