Security: replace uniqid() with random_bytes() for script tokens#58
Open
nicdavidson wants to merge 2 commits intodevelopfrom
Open
Security: replace uniqid() with random_bytes() for script tokens#58nicdavidson wants to merge 2 commits intodevelopfrom
nicdavidson wants to merge 2 commits intodevelopfrom
Conversation
Added standard overview describing DreamFactory as a secure, self-hosted enterprise data access platform for enterprise apps and on-prem LLMs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
uniqid() is microtime-based with ~20 bits of entropy, making script tokens predictable. Replace with bin2hex(random_bytes(32)) for 256-bit cryptographically secure tokens in all three script engines. Add regression tests verifying source code uses random_bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uniqid()withbin2hex(random_bytes(32))in NodeJs, Python, and Python3 script enginesuniqid()is microtime-based (~20 bits of entropy), making script auth tokens predictablerandom_bytes(32)provides 256-bit cryptographically secure tokensrandom_bytesTest plan