Revert "Fixing the share URL" - #52
Conversation
This reverts commit 1bc2efc.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| function copyShareURL(e) { | ||
| let content = decodeURIComponent(editor.getSession().getDocument().getValue()); | ||
| let content = encodeURIComponent(editor.getSession().getDocument().getValue()); |
There was a problem hiding this comment.
Compressed URL fallback shows URL-encoded content
The encodeURIComponent call on line 629 makes content URL-encoded before it's compressed in the fallback path (line 649). When loading a compressed URL, LZString.decompressFromEncodedURIComponent returns this encoded string, but there's no matching decodeURIComponent on the load path (line 860). This causes the editor to display URL-encoded content like digraph%20%7B... instead of the original content when the URL shortening service fails and the compressed fallback URL is used.
Additional Locations (1)
|
@dreampuf dude its broken again, can you please validate? |
|
@mmpataki I don't think |
2 participants
Reverts #51
Note
Fix share link generation
index.html, updatecopyShareURLto useencodeURIComponent(instead ofdecodeURIComponent) on editor content before settinglocation.hash, ensuring valid, shareable URLs.Written by Cursor Bugbot for commit 54717e6. This will update automatically on new commits. Configure here.