Separate code and add extension points - #57
Merged
Merged
Conversation
Contributor
Author
|
@dreampuf I want use GraphvizOnline as a transparent lightweight viewer for .gv/.dot files. That's why the There is a directory with RewriteCond %{QUERY_STRING} !(^|&)raw=?(&|$)
RewriteRule \.(dot|gv)$ /GraphvizOnline/index.html [END]Furthermore, I need to manipulate the SVG before it is rendered (i.e. add a CSS stylesheet) and I need to generate the DOT code from other formats and write the result to the editor. |
redneck-f25
force-pushed
the
extension-points
branch
from
March 12, 2026 19:32
981f3c1 to
9cb7f3f
Compare
dreampuf
approved these changes
Mar 16, 2026
Owner
|
This is something I haven't done because of historical issues. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For further improvements we should separate the code into separate files. Do you agree?
Especially for my use case I need extensions points to hook into the core. Later, I'll drop a note about this.