[rtl] Size the register file from ADDR_WIDTH - #5
Merged
Merged
Conversation
drewbabel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derives NumRegs from the address width so the register array is exactly as deep as the write and read index can address. It was hardcoded at four while IdxWidth followed ADDR_WIDTH, so any instantiation with a wider address space silently dropped writes above index three.
Adds prove and cover tasks at ADDR_WIDTH 5 with DATA_WIDTH 64, and at ADDR_WIDTH 6 with DATA_WIDTH 32, so the block is proved at both AXI4-Lite data widths and at a register file larger than the default. The ADDR_WIDTH 6 configuration failed before this fix and passes after, which is what caught the bug.