Annotate the serializable decorators and fix the error type of Result - #59
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 92.71% 92.70% -0.01%
==========================================
Files 35 35
Lines 1564 1563 -1
Branches 236 236
==========================================
- Hits 1450 1449 -1
Misses 49 49
Partials 65 65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two typing gaps that make
serialiteconsumers lose type information. There is no runtime behavior change.First,
serializableandabstract_serializablehad no annotations. Type checkers therefore treat every decorated class as passing through an untyped decorator and degrade or flag it. Both decorators now declare the identity signature(cls: type[T]) -> type[T], which is what checkers already assume.flexible_decoratoris typed as(dec: F) -> Fand casts its wrapper, so the inner signature is preserved through it.Second, in
_result.pythe annotated aliasFailure: type[result.Failure[Errors]]was immediately overwritten byFailure = result.Failure, so theErrorsparameterization was lost. As a result,Result[T].failure()evaluated toAnyinstead ofErrors. The plain class assignment is required because class patterns likecase Failure(...)need the actual class at runtime. The fix keeps the plain re-export and moves the parameterization into the alias.