Fix bug in nested LLVM And and Or nodes - #97
Merged
Merged
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 90.82% 90.79% -0.03%
==========================================
Files 60 60
Lines 3161 3163 +2
Branches 386 386
==========================================
+ Hits 2871 2872 +1
- Misses 208 209 +1
Partials 82 82 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When And or Or nodes are nested, there is a bug in the LLVM generation. Each assume that the operands end in the block where they started and then draw the phi nodes under that assumption. The problem is that the And and Or nodes create new blocks as part of how they work (because they are control flow). This leads to an LLVM error when a short-circuit node includes another short-circuit node.
This happens if there are 3 or more sparse operations in a row, which now has tests.