chore: bump the vitest group with 4 updates [AR-89256] - #700
chore: bump the vitest group with 4 updates [AR-89256]#700mmurawski-dn wants to merge 3 commits into
Conversation
✅ Deploy Preview for drivenets-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Generated by Claude Code |
|
Pushed a second round of fixes for One failure I'm leaving as-is: Re-verified Generated by Claude Code |
Dependabot's original PR (#694) bumped vitest, @vitest/coverage-v8, @vitest/browser-playwright to v5 and vitest-browser-react to v2.3.0, but CI failed: vitest 5's browser-mode matchers split `toHaveTextContent` into an exact-match-only assertion plus a new `toMatchTextContent` for partial/RegExp matching, and `getByRole`/`getByText` locators now need `exact: false` explicitly for substring name matching that used to be the default. This updates the affected browser tests to match. Also fixes a table test that hovered a reveal-on-hover icon directly (pointer-events: none until the parent is hovered) — hovering the parent cell first mirrors how a real pointer reaches the icon. Claude-Session: https://claude.ai/code/session_01FruzGJAvphgB11ptUBPrBt
pnpm dedupe --check (Check Unused Code and Dependencies job) flagged several transitive packages left with duplicate resolved versions after the scoped vitest update. Running pnpm dedupe collapses them, matching the dedupe step dependabot's own automation runs after a bump (.github/workflows/dependabot-side-effects.yml). Claude-Session: https://claude.ai/code/session_01FruzGJAvphgB11ptUBPrBt
Same root cause as the earlier fix: several components render an icon
glyph as literal text (material-symbols-outlined ligature) directly
adjacent to a label within one accessible-name/text run (tile links in
DsMainMenu/DsTopBarNavigation, group labels in DsDropdownMenu, status
messages in DsFileUpload, labels/values in DsKeyValuePair, breadcrumb
segments). Passing `exact: false` restores the substring name/text
matching these tests relied on before the vitest 5 upgrade.
Also fixes:
- DsMainMenu's coming-soon tooltip hover test: the badge sits inside an
aria-disabled tile: `hover({ force: true })` bypasses the stricter
actionability check the new Playwright version now enforces there.
- DsPanel's width tests: querying `getByText('Content')` synchronously
needs exact:false for the same reason as everywhere else above.
One known failure was investigated and left as-is:
`ds-comment-bubble.browser.test.tsx > should call onClose when close
button is clicked in thread` reproduces identically against the
pre-bump vitest 4.1.10 on current main, so it predates this change and
is unrelated to it.
Claude-Session: https://claude.ai/code/session_01FruzGJAvphgB11ptUBPrBt
560ca3e to
fa0dc2a
Compare
Summary
Supersedes #694, whose CI failed after the vitest 5 upgrade (
vitest,@vitest/coverage-v8,@vitest/browser-playwright→ v5.0.0,vitest-browser-react→ v2.3.0):ds-split-buttontest passed aRegExptotoHaveTextContent, which is now typedstring | number-only in vitest 5's browser matchers.toHaveTextContentjest-dom matcher into an exact-match-only assertion plus a newtoMatchTextContentfor partial/RegExp matching (see the vitest browser assertions docs). Every test that relied on the old partial-match default (checking a select trigger's text alongside its icon, a table row's text alongside other cells, a tooltip listing several names, etc.) needed to switch totoMatchTextContent.getByRole/getByTextlocators now needexact: falsepassed explicitly to get substring name matching that used to be the default (affectsds-toggle,ds-table-header-ellipsis,ds-time-picker).ds-table-editablehovered a reveal-on-hover lock icon (pointer-events: noneuntil the parent cell is hovered) directly, which the upgraded Playwright's stricter actionability check now rejects. Hovering the parent cell first (mirroring how a real pointer reaches the icon) fixes it.toHaveTextContent/RegExp issue (ds-avatar-group,ds-comments-drawer) were introduced by commits that landed onmainafter chore: bump the vitest group with 4 updates #694 was opened; fixed here too since this PR is rebased on currentmain.Added a
patchchangeset for@drivenets/design-system, matching this repo's convention for dependency-bump PRs (see.github/scripts/generate-dependabot-changeset.ts).Test plan
tsc(full package, not just affected) — 0 errorspnpm update(matches dependabot's own diff shape — only vitest and its direct transitive deps changed, no incidental churn)https://claude.ai/code/session_01FruzGJAvphgB11ptUBPrBt
Generated by Claude Code