Skip to content

Add revocable ad consent settings and centralize ad slot configuration - #57

Merged
driver727-pixel merged 2 commits into
mainfrom
copilot/review-google-ads-approval
May 22, 2026
Merged

driver727-pixel merged 2 commits into
mainfrom
copilot/review-google-ads-approval

Conversation

Copilot AI commented May 22, 2026

Copy link
Copy Markdown
Contributor

This updates the ads/settings flow so consent can be revoked after initial choice, and removes scattered empty AdSense slot placeholders in favor of a cleaner admin-ready configuration path. It also tightens the remaining approval-risk article content by reducing a long reproduced block to a brief quoted excerpt with personal framing.

  • Consent controls

    • Adds a compact Ads settings control to privacy.html with a revoke-consent action.
    • Persists the revoked state in the existing consent key used by the ad loader.
    • Exposes revokeConsent() and consent-state accessors from site-ads.js for shared front-end behavior.
  • Ad slot configuration

    • Replaces inline empty data-ad-slot="" placeholders with semantic data-ad-slot-key markers across home, search, and article placements.
    • Centralizes slot resolution in public/site-ads.js via an AD_SLOT_CONFIG map with optional window.SSF_AD_SLOTS override support.
    • Keeps unconfigured placements hidden until a real slot value is provided, which is cleaner for admin setup and safer for ad-policy handling.
  • Article tightening

    • Refactors the long reproduced manifesto block in what-vibe-coding-means-to-me-2026.html into a short quoted excerpt.
    • Keeps the passage anchored as part of the author’s life anecdote while reducing approval and copyright risk.
const AD_SLOT_CONFIG = Object.freeze({
  homepagePrimary: null,
  articleInline: null,
  searchResultsTop: null,
  searchResultsBottom: null,
  ...(window.SSF_AD_SLOTS && typeof window.SSF_AD_SLOTS === 'object' ? window.SSF_AD_SLOTS : {}),
});

// HTML
<ins class="adsbygoogle" data-ad-slot-key="articleInline"></ins>

@driver727-pixel
driver727-pixel marked this pull request as ready for review May 22, 2026 14:29
@driver727-pixel
driver727-pixel merged commit 7747a16 into main May 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants