feat: collect and add created_at and updated_at fields - fixes #90#106
Open
iarturo wants to merge 3 commits into
Open
feat: collect and add created_at and updated_at fields - fixes #90#106iarturo wants to merge 3 commits into
iarturo wants to merge 3 commits into
Conversation
feat: extract created_at and updated_at from GitHub AP
feat: add created_at and updated_at columns to README template
test: update test_extract_issue_data with date fields
drkrillo
reviewed
May 30, 2026
| 'title': row['title'].replace('|', '\\|'), # Escape '|' to avoid breaking markdown table rows | ||
| 'url': row['url'], | ||
| 'comments': row['comments'], | ||
| 'created_at': row.get('created_at', ''), |
Owner
There was a problem hiding this comment.
Cosmetic: bad indentation, you have to remove some whitespaces here
| 'comments', | ||
| 'labels', | ||
| 'state' | ||
| 'created_at', |
Owner
There was a problem hiding this comment.
Bug: You are omitting the comma after state.
| issue['comments'] = raw_issue[1]['comments'] | ||
| issue['labels'] = [l['name'] for l in raw_issue[1].get('labels', [])] | ||
| issue['state'] = raw_issue[1].get('state', 'open') | ||
| issue['created_at'] = raw_issue[1].get('created_at', '') |
Owner
There was a problem hiding this comment.
Readability: Looking good. Would be great to clean up the datetime format a little though. Probably having YYYY-MM-DD is enough. As the workflow runs daily, I don't see the need of putting time in there.
| "comments": 5, | ||
| "labels": [], | ||
| "state": "open", | ||
| "created_at": "2024-01-15T10:00:00Z", |
Owner
There was a problem hiding this comment.
Heads up:
Nice job adding the tests.
If you modify the date format as suggested, you'll need a minimum refactor here
drkrillo
requested changes
May 30, 2026
drkrillo
reviewed
May 30, 2026
|
|
||
| ## Good First Issues <sub><sub>Last run: {{today}}</sub></sub> | ||
|
|
||
| | Repo | Language | Title | Comments | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
created_atandupdated_atfields to each issue collected from the GitHub API.Both dates are now included in the CSV output and displayed in the README table.
Related Issue
Fixes #90
Checklist