Skip to content

Conversation

@drlau
Copy link
Owner

@drlau drlau commented Aug 18, 2020

This PR updates parsing resource addresses to use hashicorp/go-terraform-address.

This PR will not be merged for now because it does not handle data paths:

  • data.mydata.path
  • module.mymodule.data.mydata.path
  • module.mymodule.data.data.data
--- FAIL: TestNewResourceChangeFromComment (0.00s)
    --- FAIL: TestNewResourceChangeFromComment/handles_modules_with_data_and_data_as_the_name (0.00s)
        resource_test.go:243: Unexpected error 1:26 (25): no match found, expected: "[", [a-zA-Z0-9_-]i or EOF
    --- FAIL: TestNewResourceChangeFromComment/handles_modules_with_data (0.00s)
        resource_test.go:243: Unexpected error 1:28 (27): no match found, expected: "[", [a-zA-Z0-9_-]i or EOF
    --- FAIL: TestNewResourceChangeFromComment/handles_data (0.00s)
        resource_test.go:243: Unexpected error 1:12 (11): no match found, expected: "[", [a-zA-Z0-9_-]i or EOF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant