Add Vivaldi to supported browsers - #27
Draft
Spence1115 wants to merge 1 commit into
Draft
Conversation
Register kooky's Vivaldi finder so gh-image can extract a GitHub session cookie from Vivaldi, alongside the existing browsers. Vivaldi support isn't in a released kooky yet, so this points at a fork (browserutils/kooky#114) via a temporary replace directive. Once that lands upstream and is released, bump the kooky require and drop the replace. Verified on macOS: `check-token` authenticates via the browser cookie store, and the Vivaldi finder decrypts a real github.com user_session through this module's dependency graph.
drogers0
added
the
upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Vivaldi to supported browsers
Registers kooky's Vivaldi finder (via a one-line blank import) so gh-image can extract a GitHub
user_sessioncookie from Vivaldi, alongside the browsers already supported. Vivaldi is a mainstream Chromium-based browser that wasn't detected before.Draft — blocked on an upstream kooky release
Vivaldi support isn't in a released
kookyyet. This PR depends on browserutils/kooky#114, consumed here through a temporaryreplacedirective pointing at the fork:This stays draft until that kooky PR merges and is released. At that point: bump the
kookyrequire to the released version and delete thereplacedirective (the go.mod comment notes this). CI here builds green against the fork in the meantime.Changes
internal/cookies/cookies.go— blank-importbrowser/vivaldi. The existing selection logic is browser-agnostic, so nothing else changes functionally.README.md,documentation/architecture.md, and the bundled skill.go.mod/go.sum— temporary fork replace (see above).Verification (macOS)
go build ./...,go vet ./...,go test ./...,golangci-lint run(v2.12.2) all pass.gh image check-tokenauthenticates via the browser cookie store.user_sessionthrough this module's dependency graph (value not printed).I can only verify the macOS key store at runtime; the Linux/Windows paths ride on kooky's existing per-OS decryption (see browserutils/kooky#114).