Modify log file location#19
Open
pinpang wants to merge 4 commits into
Open
Conversation
added 3 commits
September 23, 2021 21:37
drohm
reviewed
Aug 2, 2022
Owner
drohm
left a comment
drohm
left a comment
There was a problem hiding this comment.
Can you take a look at my two comments on the pi_sht1x/logging.py file? If you can fix those I'll get this merged and do another release. Apologies for the delay getting back to this.
| @@ -1,9 +1,10 @@ | |||
| from os import path | |||
| import os | |||
Owner
There was a problem hiding this comment.
I'd prefer to use the previous import to scope the import to path, which is all we need here.
| """ | ||
| logger = getLogger(name) | ||
| log_filename = path.join(path.dirname(path.realpath(__file__)), LOG_FILE_NAME) | ||
| log_filename = os.path.join(_get_log_folder(), LOG_FILE_NAME) |
Owner
There was a problem hiding this comment.
If you change the import above you can change this to path.join.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the log file from the module installation directory to the user HOME directory.