fix: process orderByParams before baseSortParams to preserve sort order for _score and custom fields - #172
Open
zh-hanlabs wants to merge 1 commit into
Open
fix: process orderByParams before baseSortParams to preserve sort order for _score and custom fields#172zh-hanlabs wants to merge 1 commit into
zh-hanlabs wants to merge 1 commit into
Conversation
…er for _score and custom fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reorders the sort parameter processing in
WrapperProcessor.setSort()so thatorderByParams(set viaorderBy(OrderByParam)) are appended to the DSL sort array beforebaseSortParams(set viaorderByAsc/orderByDesc).Why
Currently,
setSort()processesbaseSortParamsfirst andorderByParamssecond. When a user callswrapper.orderBy(scoreParam).orderByAsc(...).orderByDesc(...), the_scoreparameter goes intoorderByParamswhile the field sorts go intobaseSortParams. SincebaseSortParamsis processed first,_scorealways ends up at the end of the DSL sort array regardless of call order, producing incorrect sorting.After this change,
orderByParamsare processed first, so the user-intended sort order is preserved in the generated DSL.How to verify
wrapper.orderBy(scoreParam).orderByAsc(status).orderByDesc(startDate)_scoreshould now appear first in the sort array, followed bystatusandstartDateCloses #164