Repository navigation
Conversation
Added empy_compat function to handle empy version differences in template processing.
Fixes unknown markup sequence python3-empy v4 and is backwards compatible with v3
There was a problem hiding this comment.
AI review
Verdict: close as already fixed. No action needed in this repo.
The @) markup this works around was already removed from the templates by
59d990d (authored
2023-01-05, landed in this repo 2025-07-13). There is no @) anywhere in the
current tree — not in templates/, not anywhere else — so empy_compat() is a
no-op on master.
I verified this directly rather than by inspection: current master generates the
uavcan, dronecan, ardupilot and com namespace roots under empy 3.3.4 and
empy 4.2.1, 373 files each, and the two outputs are byte-for-byte identical
(diff -rq clean). No ParseError under either version.
The reported traceback is from paparazzi, whose sw/ext/dronecan submodule is
pinned to an old dronecan_dsdlc that still contains @). The fix belongs there —
bump the submodule pointer — not here. Merging this would add version sniffing
that does nothing today and could mask a genuine template mistake later.
Thanks for chasing this down — you hit a real failure, it's just in an old pinned
copy rather than in current upstream. 59d990d is the commit you want on the
paparazzi side.
(The three workflow runs for this PR were sitting in action_required; I approved
them and all three — linux, regression, windows — now pass. So CI is green; the
change simply isn't needed.)
|
closing as @) gone now |
|
@tridge Awesome to coming back to it 💪 OK thanks for explanation,now I can ask to update the PPRZ uavcan submodules ... |
Fixes unknown markup sequence empy v4 and is backwards compatible with v3 . See for all the details why paparazzi/paparazzi#3663
The error will look something like this:
For example regular install of empy in Ubuntu 26.04 via
sudo apt install python3-empy,nothing exotic.