fix: Make canvas paths docroot-aware in host commands - #72
Merged
penyaskito merged 3 commits intoAug 31, 2026
Conversation
Derive the canvas module location from composer installer-paths so xb-setup, xb-cypress, and xb-playwright work with both docroot=web and docroot="" projects (including Drupal core-style checkouts with drupal-dev). Also update README setup/usage wording to reflect docroot-agnostic behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
amateescu
reviewed
Aug 19, 2026
Move docroot-aware canvas path resolution into a shared host helper script and reuse it from xb-setup, xb-cypress, and xb-playwright. This removes duplicated logic and keeps path derivation consistent across commands. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keeps the shared helper in sync on add-on upgrades, matching the marker convention DDEV's upgrade path and post_install_actions cleanup key off. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derive the canvas module location from composer installer-paths so xb-setup, xb-cypress, and xb-playwright work with both docroot=web and docroot="" projects (including Drupal core-style checkouts with drupal-dev). Also update README setup/usage wording to reflect docroot-agnostic behavior.
LLM assistance was used to build this PR